[autothrottle] optionally skip auto-delete throttle #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mborst
approved these changes
Nov 21, 2023
dopuskh3
approved these changes
Nov 21, 2023
mjd95
deleted the
mjd95/STREAMS-2248-optionally-skip-autothrottle-deletion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autothrottle will on restart / periodically attempt to delete throttles that are not known to it (either via a reassignment or via an override set via the autothrottle API).
In some situations this can be a problem, e.g. in a cluster supporting both ZK-mode and ZK-less reassignments autothrottle might delete throttles for a reassignments in the "other" mode.
Adding an option to skip GCing the unknown throttles, but keep the existing behaviour by default.